Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: in dbt_project.yml prior to v1.7 #4463

Open
1 task done
dbeatty10 opened this issue Nov 14, 2023 · 0 comments
Open
1 task done

metrics: in dbt_project.yml prior to v1.7 #4463

dbeatty10 opened this issue Nov 14, 2023 · 0 comments
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Nov 14, 2023 •
edited
Loading

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/dbt_project.yml

What part(s) of the page would you like to see updated?

metrics: is a valid top-level key in dbt_project.yml prior to v1.7, so we should figure out if we want to add it to the docs or not..

Put another way, we should determine if the config options shown for 1.6 (and a couple prior versions) are what we want in regards to metrics:.

Additional information

Instigated by #4442
@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Nov 14, 2023
@dbeatty10 dbeatty10 mentioned this issue Nov 14, 2023
Merged
3 tasks
dbeatty10 added a commit that referenced this issue Nov 16, 2023
@dbeatty10
Semantic Layer configs for dbt_project.yml (#4442)
f45199d 
Resolves #4436
Resolves #4441

### Previews
-
[v1.6](https://docs-getdbt-com-git-dbeatty-semantic-layer-dbt-79c193-dbt-labs.vercel.app/reference/dbt_project.yml?version=1.6)
-
[v1.7](https://docs-getdbt-com-git-dbeatty-semantic-layer-dbt-79c193-dbt-labs.vercel.app/reference/dbt_project.yml?version=1.7)

## What are you changing in this pull request and why?

The only substantive change is in
e40903c.

The rest of the diff is covered by
83a2e62, which was a duplication of the
spec from v1.6 into v1.7.

To keep this PR small and easy to merge, deferring to #3957 to flesh out
the other relevant pages for the semantic model configs and metric
configs. As part of #3957, this page should be updated with links to the
actual config pages once they are created.

### Other

Opened #4463 to figure out how many versions back we want to add
`metrics:`.

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.
- [x] I have checked that the previews render correctly across versions
1.6 and 1.7
- [x] I have confirmed that these config options work in 1.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbeatty10