Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add whitespace control warning in generate_schema_name macro mentions #4910

Closed
1 task done
mirnawong1 opened this issue Feb 14, 2024 · 0 comments · Fixed by #4931
Closed
1 task done

Add whitespace control warning in generate_schema_name macro mentions #4910

mirnawong1 opened this issue Feb 14, 2024 · 0 comments · Fixed by #4931
Assignees
@mirnawong1
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows

Comments

@mirnawong1
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

Per slack thread, a user reported that we should include mentions of whitespace control in generate_schema_macro examples.

A customer overriding the generate_schema_name macro did not include the whitespace control dashes, which had some effects on their project. Perhaps we could add that as a warning in the docs anywhere we mention overriding macros.

What part(s) of the page would you like to see updated?

https://docs.getdbt.com/docs/build/custom-schemas#how-does-dbt-generate-a-models-schema-name

Additional information

No response
@mirnawong1 mirnawong1 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Feb 14, 2024
@mirnawong1 mirnawong1 self-assigned this Feb 14, 2024
@mirnawong1 mirnawong1 added the priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows label Feb 14, 2024
@mirnawong1 mirnawong1 mentioned this issue Feb 15, 2024
Merged
mirnawong1 added a commit that referenced this issue Feb 23, 2024
@mirnawong1
Add note about using whitespace control for macros (#4931)
48d2da3 
Resolves #4910

this pr adds info about needing to add whitespace (dashes or minuses) in
macro to remove whitespace adn avoid issues

#4910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirnawong1 mirnawong1

Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add note about using whitespace control for macros dbt-labs/docs.getdbt.com
1 participant
@mirnawong1