Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental parser #4990

Closed
1 task done
dbeatty10 opened this issue Feb 26, 2024 · 0 comments · Fixed by #5147
Closed
1 task done

Experimental parser #4990

dbeatty10 opened this issue Feb 26, 2024 · 0 comments · Fixed by #5147
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Feb 26, 2024 •
edited
Loading

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

See below for links to the relevant pages:

What part(s) of the page would you like to see updated?

Our docs for the experimental parser are contradictory. It is unclear if the experimental parser is currently in use or not (or which versions it applies to).

We should do the following:

  1. figure out if it is used or not
  2. make sure the pages above align with the current status

Additional information

No response
@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Feb 26, 2024
@dbeatty10 dbeatty10 mentioned this issue Feb 26, 2024
Merged
4 tasks
@dbeatty10 dbeatty10 mentioned this issue Mar 22, 2024
Merged
1 task
@dbeatty10 dbeatty10 added the dbt Core The changes proposed in this issue relate to dbt Core label Mar 22, 2024
dbeatty10 added a commit that referenced this issue Mar 25, 2024
@dbeatty10 @mirnawong1
The USE_EXPERIMENTAL_PARSER global config is not currently in use (#…
996a018 
…5147)

[Preview](https://docs-getdbt-com-git-dbeatty10-patch-2-dbt-labs.vercel.app/reference/parsing)

resolves #4990

## What are you changing in this pull request and why?

1. Make updates as requested
[here](dbt-labs/dbt-core#9535).
1. Align with
5a66d8c.

## More info

In v0.20, we introduced an "experimental" static parser. It statically
analyzes model files and is faster at parsing nodes that don't need a
full Jinja render. Starting in v1.0, this parser is **on** by default,
and is no longer experimental. It can still be toggled on/off via the
[`STATIC_PARSER` global
config](https://docs.getdbt.com/reference/global-configs/parsing#static-parser).

From
dbt-labs/dbt-core#9535 (comment):
> We haven't made any "experimental" updates since 2021 (in the leadup
to dbt-core v1.0). But we've kept the flag around for the _next_ time we
want to try some more-radical changes, and need a way to:
> - (a) let folks opt in/out
> - (b) compare timing/outputs

Put another way, the `--use-experimental-parser` /
`--no-use-experimental-parser` flags still exist (along with
`DBT_USE_EXPERIMENTAL_PARSER` environment variable), but they don't have
any effect currently; they may again in the future.

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.

---------

Co-authored-by: Mirna Wong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

The USE_EXPERIMENTAL_PARSER global config is not currently in use dbt-labs/docs.getdbt.com
1 participant
@dbeatty10