Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[May 2] Update Adapter Creation Guide for v1.8 interface changes #5104

Closed
9 tasks done
nghi-ly opened this issue Mar 18, 2024 · 2 comments · Fixed by #5421
Closed
9 tasks done

[May 2] Update Adapter Creation Guide for v1.8 interface changes #5104

nghi-ly opened this issue Mar 18, 2024 · 2 comments · Fixed by #5421
Assignees
@nghi-ly @colin-rogers-dbt
Labels
adapters content Improvements or additions to content dbt-core v1.8 external-adapters-team auto labeled issues from the adapter team improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core v1.8 Doc...

Comments

@nghi-ly
Copy link
Contributor

nghi-ly commented Mar 18, 2024 •
edited
Loading

The guide https://docs.getdbt.com/guides/adapter-creation?step=1 needs to be reviewed and updated based on the changes to the adapters interface (ie dbt-common + dbt-adapters).

When is this due?

This is needed for v1.8 (Core) + "Keep on latest version" (Cloud) and can be worked on at any time, but is due May 2nd for 1.8 final GA

related: dbt-labs/dbt-adapters#136

Changes

notes

For more context, see slack thread.
@nghi-ly nghi-ly added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Mar 18, 2024
@runleonarun runleonarun added adapter maintainers When maintainers want to add an adapter as trusted or verified external-adapters-team auto labeled issues from the adapter team adapters and removed adapter maintainers When maintainers want to add an adapter as trusted or verified labels Mar 18, 2024
@jtcohen6 jtcohen6 changed the title Describe dbt-common Update Adapter Creation Guide for v1.8 interface changes Mar 18, 2024
@runleonarun runleonarun self-assigned this Mar 19, 2024
@runleonarun runleonarun changed the title Update Adapter Creation Guide for v1.8 interface changes [April] Update Adapter Creation Guide for v1.8 interface changes Mar 19, 2024
@runleonarun runleonarun changed the title [April] Update Adapter Creation Guide for v1.8 interface changes [May 2] Update Adapter Creation Guide for v1.8 interface changes Mar 19, 2024
@runleonarun runleonarun removed their assignment Mar 19, 2024
@jtcohen6
Copy link
Collaborator

jtcohen6 commented Apr 3, 2024

Related - we also need to update this documentation now that dbt-core and adapter versions will no longer be in lockstep:

@jtcohen6 jtcohen6 mentioned this issue Apr 3, 2024
Merged
3 tasks
@nghi-ly
Copy link
Contributor Author

nghi-ly commented Apr 29, 2024

notion page for collaboration: https://www.notion.so/dbtlabs/Adapters-Creation-Guide-71cb64fab2b2404692ccc53d21ababde?pvs=4

contains the contents and links of where the docs updates should be made

@nghi-ly nghi-ly mentioned this issue May 1, 2024
Merged
5 tasks
nghi-ly added a commit that referenced this issue May 2, 2024
@nghi-ly
Update adapter creation guide (#5421)
a12f895 
## What are you changing in this pull request and why?

Update the adapter creation guide for the May 2 launch. 

closes #5104

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [x] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [x] For any deleted sections, check to see if links need to be updated
and if redirects need to be added where appropriate
- [x] For any deleted screenshots, remove image file if this is the last
reference to it
- [x] Needs review from eng
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nghi-ly nghi-ly

@colin-rogers-dbt colin-rogers-dbt

Labels
adapters content Improvements or additions to content dbt-core v1.8 external-adapters-team auto labeled issues from the adapter team improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core v1.8 Documentation
Development

Successfully merging a pull request may close this issue.

Update adapter creation guide dbt-labs/docs.getdbt.com
4 participants
@runleonarun @jtcohen6 @nghi-ly @colin-rogers-dbt