Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Change constant values for secrets #5327

Closed
emmyoop opened this issue Apr 23, 2024 · 0 comments · Fixed by #5363
Closed

[Core] Change constant values for secrets #5327

emmyoop opened this issue Apr 23, 2024 · 0 comments · Fixed by #5363
Assignees
@matthewshaver
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core
Milestone
dbt Core v1.8 Doc...

Comments

@emmyoop
Copy link
Member

emmyoop commented Apr 23, 2024

Link to the page(s) on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/dbt-jinja-functions/env_var#secrets:~:text=with%20the%20prefix-,DBT_ENV_SECRET_,-will%20be%3A

The callout should be fixed. The example is still technically correct.

Tell us more about this update

We have dropped requiring the final underscore in DBT_ENV_SECRET_ to now be DBT_ENV_SECRET.

Reviewers/Stakeholders/SMEs

@Grace

Related GitHub issues

dbt-labs/dbt-common#109

Additional information

No response
@emmyoop emmyoop added content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core labels Apr 23, 2024
@matthewshaver matthewshaver self-assigned this Apr 25, 2024
@matthewshaver matthewshaver mentioned this issue Apr 26, 2024
Merged
3 tasks
This was referenced Apr 26, 2024
Merged
Merged
runleonarun added a commit that referenced this issue Apr 26, 2024
@matthewshaver @runleonarun
DBT_ENV_SECRET syntax change (#5363)
2212bb3 
## What are you changing in this pull request and why?

Closes #5327

## Checklist
<!--
Uncomment when publishing docs for a prerelease version of dbt:
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade)
-->
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [x] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [x] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

---------

Co-authored-by: Leona B. Campbell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewshaver matthewshaver

Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core
Projects
None yet
Milestone
dbt Core v1.8 Documentation
Development

Successfully merging a pull request may close this issue.

DBT_ENV_SECRET syntax change dbt-labs/docs.getdbt.com
3 participants
@runleonarun @emmyoop @matthewshaver