-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Infer a model's primary_key
based on configured data tests and/or constraints
#5497
Comments
@nataliefiann : this might not need docs changes. please double-check with dave before closing. thanks! |
Hiya @dave-connors-3 Happy Monday - I hope you're well. I just wanted to ask if this still needs a docs update? Kind Regards |
@nataliefiann morning! i do think this should probably be documented, but I don't know where would be the most appropriate! do you have any suggestions? |
Hiya @dave-connors-3 I'll query this for you and get back to you on as soon as I have an update. Kind Regards |
Hiya @dave-connors-3 Happy Almost Friday! Would it be ok to doc it in the manifest.json page and then when the PR is created and merged, I can ref the section in the test page or constraints page? Kind Regards |
Hiya @dave-connors-3 I hope you're well. I was going over the Git issues today and realised I created a PR for this issue (from this issue a few days ago. It's just awaiting a few. I'll add you as a reviewer to the ticket and another PR I updated for it. Kind Regards |
primary_key
based on configured data tests and/or constraints
Conferred with Doug and Grace. Creating a release note for this! |
At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated.
Originating from this issue: dbt-labs/dbt-core#9824
Pull request: dbt-labs/dbt-core#10096
See these for some background:
https://github.com/dbt-labs/dbt-core/blob/7940ad5c7858ff11ef100260a372f2f06a86e71f/core/dbt/contracts/graph/nodes.py#L534-L541
The inferred
primary_key
is visible in dbt Explorer.The text was updated successfully, but these errors were encountered: