Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time spines without YAML configuration are in the process of deprecation. Please add YAML configuration for your 'metricflow_time_spine' model #5908

Closed
1 task done
dbeatty10 opened this issue Aug 8, 2024 · 3 comments · Fixed by #5882
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Aug 8, 2024

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/docs/build/metricflow-time-spine

What part(s) of the page would you like to see updated?

I'm getting this warning:

16:25:18 Time spines without YAML configuration are in the process of deprecation. Please add YAML configuration for your 'metricflow_time_spine' model. See documentation to configure: https://docs.getdbt.com/docs/build/metricflow-time-spine
image

But when I click the link, it doesn't include any information about configuring the YAML.

We should add examples of how to configure the time spines in YAML.

Additional information

Other folks have run into this warning, see dbt-labs/dbt-core#10483 (comment) for an example.

When #5857 is resolved, it should resolve this issue as well.

I was able to suppress this warning by adding the following to models/_models.yml:

models:
  - name: metricflow_time_spine
    time_spine:
      standard_granularity_column: date_day
    columns:
      - name: date_day
        granularity: day
@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Aug 8, 2024
@mirnawong1
Copy link
Contributor

hey @dbeatty10 , looks like we have a yaml example in the docs. i think we can add a <File> example to that but other than that - i believe it addressed this issue right?

@mirnawong1
Copy link
Contributor

hey @dbeatty10 , going to close this issue as i think we've resolved it here with this yaml example: https://docs.getdbt.com/docs/build/metricflow-time-spine

however, please let me know if i misunderstood and we can re-open this back up!

@dbeatty10
Copy link
Contributor Author

Yep, #5882 took care of it 💪 Thanks @mirnawong1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants