Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] what are "pure marts"? #6329

Closed
AlexVialaBellander opened this issue Oct 21, 2024 · 2 comments · Fixed by #6394
Closed

[Core] what are "pure marts"? #6329

AlexVialaBellander opened this issue Oct 21, 2024 · 2 comments · Fixed by #6394
Assignees
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core size: x-small This change will take under 3 hours to fix.

Comments

@AlexVialaBellander
Copy link

Link to the page(s) on docs.getdbt.com requiring updates

https://docs.getdbt.com/best-practices/how-we-structure/4-marts

Tell us more about this update

What do you mean with "pure marts" here? A colleague asked me and I cant explain it well enough. Could it be expanded?

Reviewers/Stakeholders/SMEs

Not sure who that would be, but probably the authors of the dbt docs. it's your opinionated guide so yea?

Related GitHub issues

No response

Additional information

No response

@AlexVialaBellander AlexVialaBellander added content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core labels Oct 21, 2024
@runleonarun
Copy link
Collaborator

Thank you for opening this issue! @dbeatty10 can you expand on pure marts or recommend another SME?

@dbeatty10
Copy link
Contributor

Current docs

image

Explanation

This is more simple than it looks! In this context, "pure marts" just means marts that do not include any time-based rollups like orders_per_day or orders_per_week, but instead use the semantic layer for dynamic and flexible downstream aggregations.

Suggestion

To avoid confusion, we could update our docs to be something like this:

Focus on entity naming. Use plain English to name the file based on the concept that forms the grain of the mart customers, orders. It's usually best to avoid including rollups on time dimensions in this layer (such as orders_per_day). Instead, consider refactoring such rollups into the semantic layer, enhancing flexibility and scalability.

@matthewshaver matthewshaver self-assigned this Oct 31, 2024
@runleonarun runleonarun added the size: x-small This change will take under 3 hours to fix. label Oct 31, 2024
@matthewshaver matthewshaver mentioned this issue Oct 31, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants