From 9a453aea53fc8716c7385d47b1d767cddd4e7aa8 Mon Sep 17 00:00:00 2001 From: ialdg <39755524+ialdg@users.noreply.github.com> Date: Sat, 30 Mar 2024 07:20:38 +0100 Subject: [PATCH 1/3] Update model-access.md Hi. This modification proposal deals with what is and what isn't a contract. Regards. IL. --- website/docs/docs/collaborate/govern/model-access.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/website/docs/docs/collaborate/govern/model-access.md b/website/docs/docs/collaborate/govern/model-access.md index d1530dd3c80..0525e471723 100644 --- a/website/docs/docs/collaborate/govern/model-access.md +++ b/website/docs/docs/collaborate/govern/model-access.md @@ -130,6 +130,8 @@ And the model contract is defined: ```yaml +[comment]: Sorry, but the following configuration doesn't specify any type of contract. However, this link: https://docs.getdbt.com/docs/collaborate/govern/model-contracts#how-to-define-a-contract, does , so I think it might be better to modify the redaction to something like "And the model access is defined:", or to modify the my_project.yml setting to add an actual contract configuration. Regards. + models: - name: my_model access: public From 35c59ecdfabb7e2920c777b310717c4be1457edf Mon Sep 17 00:00:00 2001 From: Matt Shaver <60105315+matthewshaver@users.noreply.github.com> Date: Tue, 30 Jul 2024 19:02:49 -0400 Subject: [PATCH 2/3] Update website/docs/docs/collaborate/govern/model-access.md --- website/docs/docs/collaborate/govern/model-access.md | 1 - 1 file changed, 1 deletion(-) diff --git a/website/docs/docs/collaborate/govern/model-access.md b/website/docs/docs/collaborate/govern/model-access.md index 0525e471723..6e65c21efcd 100644 --- a/website/docs/docs/collaborate/govern/model-access.md +++ b/website/docs/docs/collaborate/govern/model-access.md @@ -130,7 +130,6 @@ And the model contract is defined: ```yaml -[comment]: Sorry, but the following configuration doesn't specify any type of contract. However, this link: https://docs.getdbt.com/docs/collaborate/govern/model-contracts#how-to-define-a-contract, does , so I think it might be better to modify the redaction to something like "And the model access is defined:", or to modify the my_project.yml setting to add an actual contract configuration. Regards. models: - name: my_model From 201d86b3b519ecb463a8c9b988abd56642b507d8 Mon Sep 17 00:00:00 2001 From: Matt Shaver <60105315+matthewshaver@users.noreply.github.com> Date: Tue, 30 Jul 2024 19:03:26 -0400 Subject: [PATCH 3/3] Update model-access.md changing to access --- website/docs/docs/collaborate/govern/model-access.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/website/docs/docs/collaborate/govern/model-access.md b/website/docs/docs/collaborate/govern/model-access.md index 6e65c21efcd..b79e0a4c43f 100644 --- a/website/docs/docs/collaborate/govern/model-access.md +++ b/website/docs/docs/collaborate/govern/model-access.md @@ -124,13 +124,12 @@ For example, if you have a model config set as: -And the model contract is defined: +And the model access is defined: ```yaml - models: - name: my_model access: public