Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change event handlers to (event, datum) #1829

Open
gordonwoodhull opened this issue Apr 8, 2021 · 0 comments
Open

change event handlers to (event, datum) #1829

gordonwoodhull opened this issue Apr 8, 2021 · 0 comments

Comments

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Apr 8, 2021

d3compat.eventHandler currently takes a function(datum, event) for trivial adaptation of old event handlers.

However, to reduce confusion and facilitate eventual removal of d3@5 compatibility, I think these should use the d3@6 signature.

Of course, we might not get to it until then; if not, this is documentation. It's something I noticed when working on #1824 when fixing tests to call consistently with the active version of d3. d3compat.callHandler takes a function(event, datum)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant