New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent paging style in Carp server #78

Open

SebastienGllmt opened this issue May 26, 2022 · 0 comments

Labels

enhancement webserver

Contributor

SebastienGllmt commented May 26, 2022

There are two ways to get stable pagination:

Provide a start value and an ending block. This is because if the state of the blockchain changes, the ending block hash will change so you're guaranteed the iterator is safe.
Provide a start value and a start block. For the same reason, if the start value stops existing you will eventually get an error

In the current Carp server, we use (2) for the credential/addresses endpoint and we use a mix of both (1)+(2) for the transaction/history endpoint.

We should either decide on a style, or find some to offer both of them.

SebastienGllmt added enhancement webserver labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment