Optimize rejection of studies or show the state of rejecting in the UI #4119

Palollo · 2023-06-15T12:05:18Z

Palollo
Jun 15, 2023

Rejecting a study takes several minutes. It seems a query is sent to the database for mark every image ("instance") of every series of every study...

2023-06-14 12:08:39,978 INFO  [org.dcm4chee.arc.delete.impl.RejectionServiceImpl] (default task-307) Start rejection of 1852 instances of Study[UID=1.2.250.1.38.2.1.14.1.33216.13050561], Series[UID=null], SOPInstance[UID=null].
2023-06-14 12:08:40,333 INFO  [org.dcm4chee.arc.store.impl.StoreServiceEJB] (default task-307) user@ip->DCM4CHEE: RejectedInstance[pk=19256, time=Wed Jun 14 12:08:40 UTC 2023, code=(113037, DCM, "Rejected for Patient Safety Reasons")] of Instance[uid=1.3.12.2.1107.5.2.19.45553.2017022715043786217184065, class=1.2.840.10008.5.1.4.1.1.4] of Series[uid=1.3.12.2.1107.5.2.19.45553.2017022715043788813184069.0.0.0] of Study[uid=1.2.250.1.38.2.1.14.1.33216.13050561]
2023-06-14 12:08:41,688 INFO  [org.dcm4chee.arc.store.impl.StoreServiceEJB] (default task-307) user@ip->DCM4CHEE: RejectedInstance[pk=19257, time=Wed Jun 14 12:08:41 UTC 2023, code=(113037, DCM, "Rejected for Patient Safety Reasons")] of Instance[uid=1.3.12.2.1107.5.2.19.45553.2017022715043797406584082, class=1.2.840.10008.5.1.4.1.1.4] of Series[uid=1.3.12.2.1107.5.2.19.45553.2017022715043788813184069.0.0.0] of Study[uid=1.2.250.1.38.2.1.14.1.33216.13050561]
2023-06-14 12:08:41,744 INFO  [org.dcm4chee.arc.store.impl.StoreServiceEJB] (default task-307) user@ip->DCM4CHEE: RejectedInstance[pk=19258, time=Wed Jun 14 12:08:41 UTC 2023, code=(113037, DCM, "Rejected for Patient Safety Reasons")] of Instance[uid=1.3.12.2.1107.5.2.19.45553.2017022715055143705384118, class=1.2.840.10008.5.1.4.1.1.4] of Series[uid=1.3.12.2.1107.5.2.19.45553.2017022715043788813184069.0.0.0] of Study[uid=1.2.250.1.38.2.1.14.1.33216.13050561]
[...]

¿May it be optimized with only one query for all?

If not, then I suggest:

to respond sooner from server to the browser with something like 201 - "ok, rejecting"
and show some label in the UI to let the user see that the study is being rejected.

Currently there is some timeout and the client (browser) receives an error:

but the process in the server is still running (task-307 in this example). And the user tends to do the rejection again and it makes the process even slower because of duplicated tasks which additionally seems not well managed because some errors appearing in the log (task-300 is the new):

[...]
2023-06-14 12:09:58,224 WARN  [org.hibernate.engine.jdbc.spi.SqlExceptionHelper] (default task-300) SQL Error: 0, SQLState: 23505
2023-06-14 12:09:58,224 ERROR [org.hibernate.engine.jdbc.spi.SqlExceptionHelper] (default task-300) ERROR: duplicate key value violates unique constraint "uk_6liqevdmi0spifxf2vrh18wkp"
  Detail: Key (study_iuid, series_iuid, sop_iuid)=(1.2.250.1.38.2.1.14.1.33216.13050561, 1.3.12.2.1107.5.2.19.45553.2017022715164883897292085.0.0.0, 1.3.12.2.1107.5.2.19.45553.2017022715165942079595007) already exists.
2023-06-14 12:09:58,229 ERROR [org.hibernate.internal.ExceptionMapperStandardImpl] (default task-300) HHH000346: Error during managed flush [org.hibernate.exception.ConstraintViolationException: could not execute statement]
2023-06-14 12:09:58,229 WARN  [com.arjuna.ats.arjuna] (default task-300) ARJUNA012125: TwoPhaseCoordinator.beforeCompletion - failed for SynchronizationImple< 0:ffff0afd0464:143ebaa:64403781:cbb591, org.wildfly.transaction.client.AbstractTransaction$AssociatingSynchronization@2192fe20 >: javax.persistence.PersistenceException: org.hibernate.exception.ConstraintViolationException: could not execute statement
	at [email protected]//org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:154)
	at [email protected]//org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:181)
	at [email protected]//org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:188)
[...]

vrindanayak · 2023-07-06T14:19:58Z

vrindanayak
Jul 6, 2023
Maintainer

@Palollo : You may choose to Queue the rejection

4 replies

Palollo Jul 26, 2023
Author

Thanks @vrindanayak, it may help. But I don't see the "Queue Rejection" checkbox (I have the version 5.29.2). Is it added in the last version 5.30.0?

vrindanayak Jul 27, 2023
Maintainer

No, it's been implemented in 5.24.1 - #3343

Palollo Aug 4, 2023
Author

Ok, I was doing through "More functions"->"Reject matching studies", and I think this way is always queued and because of that the checkbox is not shown.
If I go to the menu (3 dots icon) on one of the studies I see the chekbox. When I check it (and optionally set a batch ID) the task fails with IllegalArgumentException:

2023-08-04 22:14:01,161 INFO  [org.dcm4chee.arc.qmgt.impl.TaskScheduler] (EE-ManagedExecutorService-default-Thread-256) Start processing Task{taskID=22, deviceName='dcm4chee-arc', queueName='Rejection', type=REJECT, status=IN PROCESS, scheduledTime=2023-08-04 22:13:01.648, numberOfFailures=2, errorMessage=queue=true&batchID=1a, studyInstanceUID=1.2.826.0.1.3680043.10.436.1860079709835064402973936907505740444, batchID=1a, localAET=DCM4CHEE}
2023-08-04 22:14:01,167 INFO  [org.dcm4chee.arc.qmgt.impl.TaskManagerEJB] (EE-ManagedExecutorService-default-Thread-256) Failed processing of Task{taskID=22, deviceName='dcm4chee-arc', queueName='Rejection', type=REJECT, status=IN PROCESS, scheduledTime=2023-08-04 22:13:01.648, numberOfFailures=3, errorMessage=queue=true&batchID=1a, studyInstanceUID=1.2.826.0.1.3680043.10.436.1860079709835064402973936907505740444, batchID=1a, localAET=DCM4CHEE} - retry:
: java.lang.IllegalArgumentException: queue=true&batchID=1a
        at [email protected]//org.dcm4che3.data.Code.<init>(Code.java:86)
        at deployment.dcm4chee-arc-ear-5.29.2-psql-secure.ear//org.dcm4chee.arc.entity.Task.getCode(Task.java:801)
        at deployment.dcm4chee-arc-ear-5.29.2-psql-secure.ear.dcm4chee-arc-delete-5.29.2.jar//org.dcm4chee.arc.delete.impl.RejectionTaskProcessor.process(RejectionTaskProcessor.java:71)
        at deployment.dcm4chee-arc-ear-5.29.2-psql-secure.ear.dcm4chee-arc-delete-5.29.2.jar//org.dcm4chee.arc.delete.impl.RejectionTaskProcessor$Proxy$_$$_WeldClientProxy.process(Unknown Source)
        at deployment.dcm4chee-arc-ear-5.29.2-psql-secure.ear.dcm4chee-arc-qmgt-5.29.2.jar//org.dcm4chee.arc.qmgt.impl.TaskScheduler.processTask(TaskScheduler.java:208)
        at deployment.dcm4chee-arc-ear-5.29.2-psql-secure.ear.dcm4chee-arc-qmgt-5.29.2.jar//org.dcm4chee.arc.qmgt.impl.TaskScheduler.processTasksSequential(TaskScheduler.java:143)
        at deployment.dcm4chee-arc-ear-5.29.2-psql-secure.ear.dcm4chee-arc-qmgt-5.29.2.jar//org.dcm4chee.arc.qmgt.impl.TaskScheduler.process(TaskScheduler.java:123)
        at deployment.dcm4chee-arc-ear-5.29.2-psql-secure.ear.dcm4chee-arc-qmgt-5.29.2.jar//org.dcm4chee.arc.qmgt.impl.TaskScheduler.lambda$process$0(TaskScheduler.java:112)
        at [email protected]//org.jboss.as.ee.concurrent.ControlPointUtils$ControlledRunnable.run(ControlPointUtils.java:125)
        at [email protected]//org.wildfly.security.auth.server.SecurityIdentity.runAsConsumer(SecurityIdentity.java:376)
        at [email protected]//org.wildfly.security.auth.server.Scoped.runAsConsumer(Scoped.java:112)
        at [email protected]//org.wildfly.security.auth.server.Scoped.runAs(Scoped.java:60)
        at [email protected]//org.jboss.as.ee.concurrent.SecurityIdentityUtils.lambda$doIdentityWrap$1(SecurityIdentityUtils.java:63)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at org.glassfish.javax.enterprise.concurrent//org.glassfish.enterprise.concurrent.internal.ManagedFutureTask.run(ManagedFutureTask.java:117)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:833)
        at org.glassfish.javax.enterprise.concurrent//org.glassfish.enterprise.concurrent.ManagedThreadFactoryImpl$ManagedThread.run(ManagedThreadFactoryImpl.java:227)

2023-08-04 22:14:01,168 INFO  [org.dcm4chee.arc.qmgt.impl.TaskManagerEJB] (EE-ManagedExecutorService-default-Thread-256) Reschedule Task{taskID=22, deviceName='dcm4chee-arc', queueName='Rejection', type=REJECT, status=SCHEDULED, scheduledTime=Fri Aug 04 22:16:01 UTC 2023, numberOfFailures=3, errorMessage=queue=true&batchID=1a, studyInstanceUID=1.2.826.0.1.3680043.10.436.1860079709835064402973936907505740444, batchID=1a, localAET=DCM4CHEE}

vrindanayak Oct 22, 2024
Maintainer

Not reproducible. Please retry with latest version

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize rejection of studies or show the state of rejecting in the UI #4119

{{title}}

Replies: 1 comment 4 replies

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

Select a reply

Optimize rejection of studies or show the state of rejecting in the UI #4119

Palollo Jun 15, 2023

Replies: 1 comment · 4 replies

vrindanayak Jul 6, 2023 Maintainer

Palollo Jul 26, 2023 Author

vrindanayak Jul 27, 2023 Maintainer

Palollo Aug 4, 2023 Author

vrindanayak Oct 22, 2024 Maintainer

Palollo
Jun 15, 2023

Replies: 1 comment 4 replies

vrindanayak
Jul 6, 2023
Maintainer

Palollo Jul 26, 2023
Author

vrindanayak Jul 27, 2023
Maintainer

Palollo Aug 4, 2023
Author

vrindanayak Oct 22, 2024
Maintainer