Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch fixed utils.config._get_database_engine for django 1.2.x #14

Open
Apkawa opened this issue Sep 18, 2010 · 1 comment
Open

Patch fixed utils.config._get_database_engine for django 1.2.x #14

Apkawa opened this issue Sep 18, 2010 · 1 comment

Comments

@Apkawa
Copy link

Apkawa commented Sep 18, 2010

Hi.
I written path http://paste.pocoo.org/show/263575/

In django new config as DATABASES[key]['ENGINE']

@lamby
Copy link

lamby commented Sep 12, 2011

This patch does not detect MySQL correctly - settings.DATABASES['default']['ENGINE'] is a dotted-notation string like "django.db.backends.mysql" so comparing with "mysql" is wrong.

Also, "default" should be replaced with DEFAULT_DB_ALIAS.

Also, you make an unrelated change to the end of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants