Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow update for R CMD Check #1986

Open
ddsjoberg opened this issue Sep 18, 2024 · 0 comments
Open

Workflow update for R CMD Check #1986

ddsjoberg opened this issue Sep 18, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@ddsjoberg
Copy link
Owner

ddsjoberg commented Sep 18, 2024

We currently test on the current release of R, the last version, and the dev version. Looking around here you'd think
Sure, she's got everything...but I want more 🎶

  • I want to run R CMD Check on the last 4 releases of R (this is something gtsummary has committed to in the past). There are things that need to be addressed for this:
    1. Some of the suggested deps will not be available for older versions of R. This is fine, but {pak} will error if any of the packages are not available. So we need to address that error
    2. There is an option to not error in R CMD Check when a Suggsted dep is not available. Need to find the correct flag/option to use. It's not --nosuggest.
  • We currently use the base R placeholder syntax (e.g. 1:10 |> mean(x = _)) in just one or two places. once we have our checks working on older versions of R, we can replace that syntax with magrittr pipe code and we can then support R 4.1 (instead of 4.2, where we are currently set at)
@ddsjoberg ddsjoberg added the help wanted Extra attention is needed label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant