Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer works with Manifest V3 #45

Open
mmmaggio opened this issue Dec 17, 2023 · 5 comments
Open

No longer works with Manifest V3 #45

mmmaggio opened this issue Dec 17, 2023 · 5 comments

Comments

@mmmaggio
Copy link

I've noticed a sharp decrease in usability recently on this, and tried to switch it to manifest v3. Now the js has stopped working altogether. Any solutions / suggestions? It looks like you can no longer run persistent js on chrome now.

@cspotcode
Copy link

I've got it mostly working on Manifest V3: https://github.com/cspotcode/spaces

It's ported to a service worker as dictated by manifest v3. Not sure if the service worker going idle and terminating will break things. As far as I can tell, browsers restart the service worker on demand whenever you open the extension's popup or interact with it.

I was gonna teach the extension to understand tab groups, but I dunno if I'll have time for that; Edge has this mostly built-in with Workspaces, so I might just use those.

@kiyanovsky
Copy link

I'm a developer of TabXpert extension. It has a similar session tracking approach as in Spaces, no wonder, because Spaces encouraged me to write TabXpert. I recently implemented an import from Spaces. Also, TabXpert MV3 compatible and supports Chrome tab groups, sync with Cloud and many other features.

@alieonsido
Copy link

alieonsido commented Dec 29, 2024

@cspotcode
I try to use your repo, and I found some bugs about active space name in race condition and can't trig spaces-switch
to specific closed sessions correctly.
(repo: https://github.com/alieonsido/spaces , in 20250106 it's stable enough to work on V3)
So that, I had rewritten some functions by LLM and sent pull request.
However, I'm not a front-end engineer, although I fixed wrong spaces-switch cases, but active space ID in race condition bug haven't been fixed (It works on 20250106)
maybe added some redundant & dirty codes.
More details are in pull request script.

Sincerely, thanks for your work & help, your work helps me a lot.
I really love Spaces Project.

@cspotcode
Copy link

I've stopped working on Spaces because I discovered Edge Workspaces. They do everything I need and are built-in to the browser, and I haven't hit the occasional syncing and tab duplication bugs that seem inevitable with extension-based solutions. Though to be fair, I never tried any paid options.

https://www.youtube.com/watch?v=1kJ59DzjNOU

Anyway, I'm posting this because I don't want anyone to waste time sending me pull requests, but feel free to take my code for your own fork.

@alieonsido
Copy link

@cspotcode
Again, Thanks for your contribution to help me finish thr porting work and Happy New Year m(_ _)m
I sent PR to deanoemcke Repo after I had sent to you, sorry about the inconvenience Which I did.

Everybody interested in my Porting V3 Version could go to my repo mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants