Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: markdown formatting #6

Closed
dalechyn opened this issue Apr 6, 2023 · 6 comments
Closed

feat: markdown formatting #6

dalechyn opened this issue Apr 6, 2023 · 6 comments

Comments

@dalechyn
Copy link

dalechyn commented Apr 6, 2023

Would be nice to see some formatted code as pr-codex sometimes references to the code functions objects etc

@jjranalli
Copy link
Contributor

@h0tw4t3r makes sense. Could you link a comment to use as reference?

@dalechyn
Copy link
Author

dalechyn commented Apr 6, 2023

@jjranalli,

Tldr

Added cookie-parser to package.json, added AuthGuard to auth.controller, added AuthService to auth.guard.spec.ts.

Detailed summary

  • Added "cookie-parser": "^1.4.6" to package.json
  • Added AuthGuard to auth.controller.ts
  • Added AuthService to auth.guard.spec.ts
  • Imported CanActivate and AuthGuard to auth.controller.spec.ts
  • Added a mockAuthGuard to auth.controller.spec.ts
  • Modified getNonce() in auth.controller.ts to send response instead of returning string
  • Modified auth() in auth.controller.ts to send true instead of empty response
  • Added validate() and logout() methods to auth.controller.ts
  • Implemented validate() method in auth.controller.ts to send true and set content type to text/plain
  • Implemented logout() method in auth.controller.ts to send true and clear cookies
  • Modified getNonce() in auth.controller.spec.ts to check response.send() is called with a string
  • Modified auth() in auth.controller.spec.ts to check response.send() is called with true
  • Implemented validate() method in auth.controller.spec.ts to check response.send() is called with true and content type is set to text/plain
  • Implemented logout() method in auth.controller.spec.ts to check response.send() is called with true, content type is set to text/plain and cookies are cleared
  • Imported Request and Response from express to auth.guard.spec.ts
  • Modified canActivate() in auth.guard.ts to check if access token is valid and call canActivateViaRefreshToken() if it's not.
  • Implemented canActivate() method in auth.guard.spec.ts to check if canActivateViaRefreshToken() is called when access token is invalid.

The following files were skipped due to too many changes: pnpm-lock.yaml.

@jjranalli
Copy link
Contributor

To make sure I understand this, it appears that in most comments it uses backticks to format filenames (ie paradigmxyz/flux#63 (comment)). However in the comment shared above this doesn't seem to be happening. So is it not consistent?

@dalechyn
Copy link
Author

dalechyn commented Apr 6, 2023

To make sure I understand this, it appears that in most comments it uses backticks to format filenames (ie paradigmxyz/flux#63 (comment)). However in the comment shared above this doesn't seem to be happening. So is it not consistent?

Yeah, you're absolutely right, it is not consistent.

I don't really know, maybe we should lower the temperature and tell it a bit more forcefully to style code?

image

@jjranalli
Copy link
Contributor

jjranalli commented Apr 6, 2023

@h0tw4t3r Let's see if #7 works, and if that's not enough we can try lowering temp. If the comment shared above is in one of your repos, can you push a commit and see how does the new pr-codex comment look?

@jjranalli
Copy link
Contributor

closing this for now, feel free to reopen if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants