Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Opening JSON Key Path unless It's an IO Object #133

Open
cacheflow opened this issue Dec 18, 2024 · 0 comments · May be fixed by #134
Open

Prevent Opening JSON Key Path unless It's an IO Object #133

cacheflow opened this issue Dec 18, 2024 · 0 comments · May be fixed by #134

Comments

@cacheflow
Copy link

Currently, in the json_key method it assumes that json_key_path will be an IO-like object. This can cause an issue where if someone accidentally passes their credentials in plaintext or a non-IO like object, the Gem will attempt to open the credentials and they'll be displayed in plain text.
@cacheflow cacheflow linked a pull request Dec 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure JSON Key Path is an Actual File or IO Object cacheflow/fcm
1 participant
@cacheflow