Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast forward/backward on long press video sides #262

Open
ThigSchuch opened this issue May 30, 2022 · 2 comments
Open

Fast forward/backward on long press video sides #262

ThigSchuch opened this issue May 30, 2022 · 2 comments
Labels
P2 random bugs & feature requests page:viewer type:feature New feature or request video

Comments

@ThigSchuch
Copy link

ThigSchuch commented May 30, 2022

Is your feature request related to a problem? Please describe.
It's not related to a problem, but an alternative to skip parts of the video.

Describe the solution you'd like
Use the same behavior of Telegram's video player when you long press right for fast forward or left for fast backward.
Video speeds changes to 2x apparently.

It's more precise when you jump 10~20 seconds and want go backward just a few seconds.
You can fast forward but still can see what is happening, and you need to change speed and reset speed many times.

Additional context

video_2022-05-30_18-40-46.mp4
@ThigSchuch ThigSchuch added the type:feature New feature or request label May 30, 2022
@deckerst
Copy link
Owner

I agree this would be nice, but I'm limited by the capabilities of the video library I'm using.

This video library is weak when it comes to seeking and changing speed. For example, changing speed is only possible for videos with an audio track, and changing speed restarts playing from the previous key frame, so it wouldn't be a smooth experience like the one you know.

If I find a better video library that can do what you suggest, I'd gladly implement it, but as it is I don't think I can.

@deckerst deckerst added P3 valid issue to be addressed in the future video labels May 31, 2022
This was referenced Jun 26, 2023
@deckerst deckerst added page:viewer P2 random bugs & feature requests and removed P3 valid issue to be addressed in the future video:engine labels Jan 6, 2024
@deckerst
Copy link
Owner

I've changed the video engine in mid 2023, and recently that engine got even better with regards to video seeking.

I would likely handle long pressing on left/right sides (not edges). Need to check whether it's compatible with the vertical drag gestures to change volume & brightness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 random bugs & feature requests page:viewer type:feature New feature or request video
Projects
None yet
Development

No branches or pull requests

2 participants