Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harness: Update eth to work with geth 1.14 and up. #3123

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

harness: Update eth to work with geth 1.14 and up. #3123

wants to merge 3 commits into from

Conversation

JoeGruffins
Copy link
Member

@JoeGruffins JoeGruffins commented Dec 18, 2024 •
edited
Loading

closes #3122

Also no longer using the deprecated personal namespace

@JoeGruffins
Copy link
Member Author

Does polygon need all the same changes?

@JoeGruffins JoeGruffins force-pushed the updateethharness branch 3 times, most recently from b5883f0 to f8ce2cf Compare December 20, 2024 09:22
JoeGruffins
JoeGruffins commented Dec 20, 2024
View reviewed changes
dex/testing/btc/base-harness.sh
@@ -114,7 +114,7 @@ tmux send-keys -t $SESSION:0 "${DAEMON} -rpcuser=user -rpcpassword=pass \
-rpcport=${ALPHA_RPC_PORT} -datadir=${ALPHA_DIR} $(deprecateddbd $ALPHA_DESCRIPTOR_WALLET) \
-debug=rpc -debug=net -debug=mempool -debug=walletdb -debug=addrman -debug=mempoolrej \
-whitelist=127.0.0.0/8 -whitelist=::1 \
-txindex=1 -regtest=1 -port=${ALPHA_LISTEN_PORT} -fallbackfee=0.00001 \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Bitcoin core v28.0.0 for some reason this wasn't using the port anymore. Using bind seems to work...

Copy link
Contributor

@dev-warrior777 dev-warrior777 Dec 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried bitcoin core v22-1 and it accepts -bind=12345 but does not make a listening tcpip port.

2024-12-25T07:55:25Z Command-line arg: bind="12345"
2024-12-25T07:55:25Z Command-line arg: server="1"

netstat -tl <- no new port. i.e. it fails silently!

-port=12345 does make port:

tcp        0      0 0.0.0.0:12345           0.0.0.0:*               LISTEN     
tcp6       0      0 [::]:12345              [::]:*                  LISTEN

@JoeGruffins JoeGruffins marked this pull request as ready for review December 20, 2024 09:24
@JoeGruffins
Copy link
Member Author

I was going to update the internal eth nodes, but its adding a toolchain to the go.mod and we didn't want that for some reason. I guess we will have to add it to update though?

@JoeGruffins
Copy link
Member Author

The harness just mines whenever there is a transaction, which is unfortunate, but the mining scrip needs to be updated to reflect this. Also some tests in /client/asset/eth are broken still.

@JoeGruffins
Copy link
Member Author

Fixing the mining script https://github.com/decred/dcrdex/compare/726f473c18811544c6624b9239ddb78b555fe86f..b983ef294ec3571e685b9751863fc5de947ab172

I also tried setting --dev.period 10 but for some reason no transactions are mined then. That may be useful for testing if we can figure it out.

@JoeGruffins
Copy link
Member Author

Fixing tests and apparently gas for token swaps is less now https://github.com/decred/dcrdex/compare/b983ef294ec3571e685b9751863fc5de947ab172..4f832ebf1086d67112a0cae15b7c3a55c65032ae

Also, I had to update to 1.14.12 because HeaderByNumber was returning an incorrect header on simnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dev-warrior777 dev-warrior777 dev-warrior777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

harness: Update to work with geth v1.13.x +
2 participants
@JoeGruffins @dev-warrior777