Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets that mature and are called to vote in the same block are sometimes not voted #249

Open
jolan opened this issue Jan 23, 2018 · 2 comments
Labels

Comments

@jolan
Copy link
Contributor

jolan commented Jan 23, 2018

stakepoold acts on notifications from dcrd but since the winning tickets notification typically arrives before the new tickets notification, we won't properly vote when a newly matured ticket is called to vote since live tickets are only appended when they mature.

@jolan jolan self-assigned this Jan 23, 2018
@jolan jolan changed the title tickets that mature and are called to vote in the same block are not voted tickets that mature and are called to vote in the same block are sometimes not voted Jan 23, 2018
@ebonetti
Copy link

ebonetti commented Oct 25, 2019

With some guidance from @JoeGruffins I'd like to tackle this issue as a bug regarding the interaction between dcrstakepool, dcrd and dcrwallet.

Steps:

  1. local dcrd and dcrwallet simnet using Docker Compose (or similar), possibly with diffusion lag as parameter.
  2. dcrstakepool on Docker, useful for understanding how it works and how to improve docs.
  3. dcrd, dcrwallet and dcrstakepool on a Docker simnet.
  4. unit test to elicit the current issue
  5. resolution and evaluation with unit test.

If you have any feedback or suggestions please let me know ;)

Enrico

@ebonetti
Copy link

ebonetti commented Nov 4, 2019

I noticed that writing simnet tests for point 1) should be an extension of rpctest which right now is broken. It does exist decred/dcrwallet#1275, which I could build upon, but I don't really see it getting merged anytime soon. Same with gRPC simnet tests decred/dcrwallet#1298.

So since base dcrwallet simnet tests are not yet in place, dcrstakepool simnet test approach is not gonna work right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants