-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Check that cold wallet key and voting wallet key are not the same #407
Comments
While working on this issue I had the idea that the voting key should be taken out of the config all together. The readme specifies that the "default" account should be used anyway. We can get that pubkey programmatically and there's no reason to have the user input it then check it. |
Having dcrstakepool programmatically retrieve the voting wallet pubkey seems like a good idea. I guess the solution would be something like:
@chappjc any thoughts about this? |
Solution concept is good and will be a welcome change to ops. I did a very superficial review of #422, but it looks to be going in a good direction. I'd like to review that more closely though. |
According to @dajohi there have been cases in the past where users have attempted to use the same wallet and/or account for both voting and collecting voting fees.
We can help VSP operators to avoid these kind of mistakes by adding some simple checks to the code, either check if the 2x pubkeys are identical, or check if they belong to 2x distinct wallets. The former is trivial to implement, I am not sure if RPCs exist for the latter.
The text was updated successfully, but these errors were encountered: