You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! First of all, thank you for the great library - it has been a joy to use!
I have a question about the Pelt search algorithm. In the Pelt class, the _seg method first computes the new additional cost for each chosen breakpoint and admissible partition before that. This is done at line 71:
But then, when pruning non-optimal partitions, at lines 77-81
admissible = [
t
for t, partition in zip(admissible, subproblems)
if sum(partition.values()) <= sum(partitions[bkp].values()) + pen
]
the condition (if ...) in the list comprehension adds a new penalty term pen to sum(partitions[bkp].values(). I am struggling to understand, since the algorithm you describe on p.21 of the paper does not add this second penalty term.
Is this a mistake or am I misunderstanding something? I'd be grateful for your help.
The text was updated successfully, but these errors were encountered:
Hi! First of all, thank you for the great library - it has been a joy to use!
I have a question about the Pelt search algorithm. In the
Pelt
class, the_seg
method first computes the new additional cost for each chosen breakpoint and admissible partition before that. This is done at line 71:tmp_partition.update({(t, bkp): self.cost.error(t, bkp) + pen})
But then, when pruning non-optimal partitions, at lines 77-81
the condition (
if
...) in the list comprehension adds a new penalty termpen
tosum(partitions[bkp].values()
. I am struggling to understand, since the algorithm you describe on p.21 of the paper does not add this second penalty term.Is this a mistake or am I misunderstanding something? I'd be grateful for your help.
The text was updated successfully, but these errors were encountered: