Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request #26

Closed
Redmar-van-den-Berg opened this issue Mar 21, 2024 · 7 comments · Fixed by #36
Closed

Feature request #26

Redmar-van-den-Berg opened this issue Mar 21, 2024 · 7 comments · Fixed by #36

Comments

@Redmar-van-den-Berg
Copy link
Contributor

Would it be possible to add an option to specify the HLA database folder to use, rather than using the hardcoded 'db' option?

@wshuai294
Copy link
Collaborator

Hi, we can certainly add an option. The database (db) is a customized database created by SpecHLA. Could you please elaborate on the utility of this option or specify the scenarios where it would be applicable? Thanks.

@Redmar-van-den-Berg
Copy link
Contributor Author

When I'm creating a pipeline, I like to have a small test dataset (of both samples and reference files) that I can quickly run to test that the pipeline is working (ideally, it should run in a few seconds). So my use case for this request would be to shrink the database down to only include the alleles that I know are present in my test samples, and then use the small database to test the pipeline I'm working on.

@wshuai294
Copy link
Collaborator

Hi, the database contains complex information, which makes it difficult to shrink. We do not recommend modifying it. However, even with the original database, SpecHLA can process the provided example data (exon) within a few minutes. If your test data consists of reads from a single gene, it will be even faster. Therefore, we believe the test time should be acceptable with the original database. Thanks.

@Redmar-van-den-Berg
Copy link
Contributor Author

I understand, but I still think it would be nice to not have things like the database location or the conda environment hard coded. Hard coded values make it much more difficult to use the tool and integrate it in other systems, for example conda or biocontainers.

@wshuai294 wshuai294 reopened this Mar 28, 2024
@wshuai294
Copy link
Collaborator

Agreed, we will add this option as suggested soon. Thanks.

@Redmar-van-den-Berg
Copy link
Contributor Author

@wshuai294 I'm happy to help out with this, would you like me to create a pull request for this functionality?

@wshuai294
Copy link
Collaborator

Hi, sorry for the delay. It will be greatly appreciated if you create a pull request for this functionality! Thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants