Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TorchModel typing for fname argument in save is str, but is used as pathlib.PosixPath #1420

Open
yurakuratov opened this issue Mar 24, 2021 · 0 comments
Open

TorchModel typing for fname argument in save is str, but is used as pathlib.PosixPath #1420

yurakuratov opened this issue Mar 24, 2021 · 0 comments
Labels
bug

Comments

@yurakuratov
Copy link
Contributor

fname argument of TorchModel.save() is expected to be str, but is actually used as pathlib.PosixPath
https://github.com/deepmipt/DeepPavlov/blob/master/deeppavlov/core/models/torch_model.py#L172

Support, please, both types of arguments or fix typing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yurakuratov