Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the mime crate for parsing the Accept header #154

Closed
thomastaylor312 opened this issue Jun 10, 2021 · 2 comments · Fixed by #169
Closed

Use the mime crate for parsing the Accept header #154

thomastaylor312 opened this issue Jun 10, 2021 · 2 comments · Fixed by #169
Assignees
Labels
good first issue Good for newcomers

Comments

@thomastaylor312
Copy link
Contributor

Currently our code does some manual parsing, now that #153 is using the mime library for proper parsing, we should replace some of our own code with it in the SerializedData type

@thomastaylor312 thomastaylor312 added the good first issue Good for newcomers label Jun 10, 2021
@technosophos
Copy link
Contributor

Blocked on hyperium/mime#139

mime does not have TOML. (Right now, it is also missing Wasm, but there is a PR for that hyperium/mime#138)

Given the low rate of PR merges on that repo (one merge in 2020, none in 2021), we might just close this. If anyone knows @seanmonstar or any of the other Hyperium devs, maybe we should volunteer as co-maintainers on that repo. It's low activity, and getting more MIME types supported is definitely desirable.

@technosophos
Copy link
Contributor

Okay, so on further clarification from @thomastaylor312, I am trying to switch over from strings to mime's types throughout Bindle. The above will not block this PR (though it would still be good to get application/toml into mime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants