Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT COMMIT: Add support for mTLS auth #316

Closed
wants to merge 1 commit into from
Closed

DO NOT COMMIT: Add support for mTLS auth #316

wants to merge 1 commit into from

Conversation

lann
Copy link
Contributor

@lann lann commented Feb 28, 2022

Fixes #312

@ghost
Copy link

ghost commented Feb 28, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@lann
Copy link
Contributor Author

lann commented Feb 28, 2022

As written this depends on seanmonstar/warp#942 being merged. Another possible approach would be to extract client cert with a Tower layer, though from a brief review that looks like significantly more work unless I am missing an existing crate.

radu-matei
radu-matei reviewed Feb 28, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@lann lann closed this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radu-matei radu-matei radu-matei left review comments

@thomastaylor312 thomastaylor312 Awaiting requested review from thomastaylor312 thomastaylor312 will be requested when the pull request is marked ready for review thomastaylor312 is a code owner

@technosophos technosophos Awaiting requested review from technosophos technosophos will be requested when the pull request is marked ready for review technosophos is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mTLS auth
2 participants
@lann @radu-matei