Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoice object returns a Vec<Parcel> as type "parcel" #333

Open
bacongobbler opened this issue Apr 27, 2022 · 3 comments
Open

invoice object returns a Vec<Parcel> as type "parcel" #333

bacongobbler opened this issue Apr 27, 2022 · 3 comments

Comments

@bacongobbler
Copy link
Contributor

Should these fields be made plural to match other fields?

pub parcel: Option<Vec<Parcel>>,
pub group: Option<Vec<Group>>,
pub signature: Option<Vec<Signature>>,

IMO we should be listing these as "parcels", "groups", and "signatures" as we're dealing with a list of objects rather than a single object.

That being said, this would break backwards compatibility with older bindle clients.

I noticed this while updating bindle-dotnet to the newest bindle APIs.

@thomastaylor312
Copy link
Contributor

We had it that way originally but changed our minds for a specific reason I can't remember. @technosophos do you remember?

@itowlson
Copy link
Contributor

#34

@thomastaylor312
Copy link
Contributor

Yeah that is where we changed it, but we had an "in person" discussion about why we were doing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants