From 3be3a4c155bea1754ec8432326b1cd47398999b4 Mon Sep 17 00:00:00 2001 From: Lin Zhou Date: Fri, 27 Sep 2024 16:05:03 -0700 Subject: [PATCH] fix comments --- .../io/delta/standalone/internal/DeltaSharedTable.scala | 7 +++---- .../io/delta/sharing/server/DeltaSharingServiceSuite.scala | 3 +-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/server/src/main/scala/io/delta/standalone/internal/DeltaSharedTable.scala b/server/src/main/scala/io/delta/standalone/internal/DeltaSharedTable.scala index ad7006da2..222af436e 100644 --- a/server/src/main/scala/io/delta/standalone/internal/DeltaSharedTable.scala +++ b/server/src/main/scala/io/delta/standalone/internal/DeltaSharedTable.scala @@ -505,7 +505,7 @@ class DeltaSharedTable( null } // For backwards compatibility, return an `endStreamAction` object only when - // `includeRefreshToken` is true or `maxFiles` is specified + // `includeRefreshToken` is true, `maxFiles` is specified or includeEndStreamAction. filteredFiles ++ { if (includeRefreshToken || maxFiles.isDefined || includeEndStreamAction) { Seq(getEndStreamAction(nextPageTokenStr, minUrlExpirationTimestamp, refreshTokenStr)) @@ -646,10 +646,9 @@ class DeltaSharedTable( case _ => () } } - // Return an `endStreamAction` object only when `maxFiles` is specified for - // backwards compatibility. + // Return an `endStreamAction` object only when `maxFiles` or includeEndStreamAction is + // specified for backwards compatibility. if (maxFilesOpt.isDefined || includeEndStreamAction) { - // TODO(Ask why nextPageTokenStr is always null actions.append(getEndStreamAction(null, minUrlExpirationTimestamp)) } actions.toSeq diff --git a/server/src/test/scala/io/delta/sharing/server/DeltaSharingServiceSuite.scala b/server/src/test/scala/io/delta/sharing/server/DeltaSharingServiceSuite.scala index 9052d6623..7ba219655 100644 --- a/server/src/test/scala/io/delta/sharing/server/DeltaSharingServiceSuite.scala +++ b/server/src/test/scala/io/delta/sharing/server/DeltaSharingServiceSuite.scala @@ -189,8 +189,7 @@ class DeltaSharingServiceSuite extends FunSuite with BeforeAndAfterAll { if (includeEndStreamAction) { expectedHeader += s";includeendstreamaction=true" } - assert(responseCapabilities == expectedHeader, - s"Incorrect response format: $responseCapabilities") + assert(responseCapabilities == expectedHeader, s"Incorrect header: $responseCapabilities") } val deltaTableVersion = connection.getHeaderField("Delta-Table-Version") expectedTableVersion.foreach { v =>