Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit options for "Delete Messages from Server" for chatmail accounts #4113

Closed
iequidoo opened this issue Sep 8, 2024 · 1 comment · Fixed by #4276
Closed

Limit options for "Delete Messages from Server" for chatmail accounts #4113

iequidoo opened this issue Sep 8, 2024 · 1 comment · Fixed by #4276
Assignees
@Simon-Laux
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@iequidoo
Copy link

iequidoo commented Sep 8, 2024

Only the following options make sense for chatmail:

  • Automatic (delete_server_after=0 i.e. the server decides when to delete messages).
  • At once after Download (delete_server_after=1).

See deltachat/deltachat-android#3147 for the reference implementation. NB: Auto-adjusting of delete_server_after isn't needed, Core >= 1.143 will do that on its own (see deltachat/deltachat-core-rust#5840).

Probably this may be done even after switching to new Core, but better before -- at least for consistency with DC Android.
@iequidoo iequidoo added the enhancement New feature or request label Sep 8, 2024
@iequidoo
Copy link
Author

iequidoo commented Sep 8, 2024

The same issue for iOS: deltachat/deltachat-ios#2296

@Simon-Laux Simon-Laux added the good first issue Good for newcomers label Oct 2, 2024
@Simon-Laux Simon-Laux self-assigned this Oct 26, 2024
Simon-Laux added a commit that referenced this issue Oct 26, 2024
@Simon-Laux
Limit options for "Delete Messages from Server" for chatmail accounts
83d7168 
closes #4113
@Simon-Laux Simon-Laux mentioned this issue Oct 26, 2024
Merged
Simon-Laux added a commit that referenced this issue Oct 26, 2024
@Simon-Laux
Limit options for "Delete Messages from Server" for chatmail accounts
37c349d 
closes #4113
Simon-Laux added a commit that referenced this issue Oct 27, 2024
@Simon-Laux @WofWca
Limit options for "Delete Messages from Server" for chatmail accounts (…
d4e658e 
…#4276)

* Limit options for "Delete Messages from Server" for chatmail accounts

closes #4113

* Apply suggestions from code review

Co-authored-by: WofWca <[email protected]>

* Update packages/frontend/src/components/Settings/Autodelete.tsx

Co-authored-by: WofWca <[email protected]>

* fix fmt

---------

Co-authored-by: WofWca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simon-Laux Simon-Laux

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit options for "Delete Messages from Server" for chatmail accounts deltachat/deltachat-desktop
2 participants
@Simon-Laux @iequidoo