Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected "Escape" key behaviours #4128

Open
r10s opened this issue Sep 12, 2024 · 3 comments
Open

unexpected "Escape" key behaviours #4128

r10s opened this issue Sep 12, 2024 · 3 comments
Labels
accessibility bug Something isn't working

Comments

@r10s
Copy link
Member

r10s commented Sep 12, 2024

the "Escape" key is working only in some situations, and not always predictable.

some inconsistencies:

  • settings -> esc works
  • settings -> chats and media -> esc does not work (there is a dedicated issue for that at Settings should be closable in sub-pages with escape key #3868)
  • settings -> chats and media -> back -> esc does not work
  • enlarge image -> esc works
  • enlarge image -> context menu -> esc closes image and keeps context menu
  • enlarge image -> context menu -> close context menu -> esc does not work

EDIT: some more:

  • chat -> context menu -> esc works
  • chat -> reaction menu -> esc does not work
@r10s r10s added the bug Something isn't working label Sep 12, 2024
@WofWca
Copy link
Collaborator

WofWca commented Sep 12, 2024

FYI some of these might get resolved in the Blueprint removal MR.

@maxphilippov
Copy link
Collaborator

maxphilippov commented Oct 7, 2024

Turns out none of these are solved by #4006 cause a lot of the dialogs are actually implemented as a switch between different states rather than stacking, but this looks like a pretty straightforward refactor, I'll probably do that after Blueprint removal PR is merged since there's a lot of Dialog-related code

UPD: I realized that ContextMenu-related things are probably actually solved by the PR, after I solve a little bug reported by Simon in #4006, cause ContextMenu is now a part of the dialog stack.

@maxphilippov
Copy link
Collaborator

  • enlarge image -> context menu -> esc closes image and keeps context menu

Just as an update for someone who's gonna work on this. On current main after Blueprint removal:

  • enlarge image -> context manu -> esc closes both image and menu
    Should close context menu first, I believe, so this is still a bug, just different behaviour
  • enlarge image -> context menu -> close context menu -> esc does not work

Escape works now

These are fixed in #4205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants