Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Dell XPS 13 #20

Open
RasmusLindroth opened this issue May 6, 2019 · 1 comment
Open

Add support for Dell XPS 13 #20

RasmusLindroth opened this issue May 6, 2019 · 1 comment
Assignees

Comments

@RasmusLindroth
Copy link

Hi!

As you have stated in the readme it doesn't support all types of laptop batteries. To support for Dell XPS 13, and other laptops from Dell I suppose, you would need these changes.

RasmusLindroth@a534134

I could help you implement it but I'm not sure what the best way is. One alternative would be to would have to state your model in the configuration file, but I think the more cleaner solution would be to check if either POWER_SUPPLY_ENERGY_FULL or POWER_SUPPLY_CHARGE_FULL is set in /sys/class/power_supply/BAT0/subsystem/...

By the way, thank you for your software :)

@denbeigh2000
Copy link
Owner

Hey, thanks for the report!

I think the best way to approach this is to (finally!) remove my sketchy uevent parsing, likely in favour of an external library like https://github.com/distatus/battery.

I should have some time to tend to this in a week or two, when there is less real life in the way :-)

Thanks for using my software!

@denbeigh2000 denbeigh2000 self-assigned this Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants