Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mailers need separate tests #627

Open
denny opened this issue Oct 6, 2020 · 2 comments
Open

Mailers need separate tests #627

denny opened this issue Oct 6, 2020 · 2 comments
Labels
good first issue This issue should be suitable for less experienced developers help offered I would be very happy to help less experienced developers tackle this issue (advice/pairing/etc) main app DEPRECATED: main_app before the core plugin refactor (was: 'core' stuff that isn't in plugins) mjml Involves MJML, or the code that handles it plugin DEPRECATED: split into core/features/support (was: about a plugin or the code that supports them) tests Tests and test infrastructure (CI, etc)

Comments

@denny
Copy link
Owner

denny commented Oct 6, 2020 •
edited
Loading

Currently most of the mailer code is only 'tested' indirectly, when the request specs touch a controller action that touches a model method that touches the mailer.
@denny denny added good first issue This issue should be suitable for less experienced developers plugin DEPRECATED: split into core/features/support (was: about a plugin or the code that supports them) tests Tests and test infrastructure (CI, etc) main app DEPRECATED: main_app before the core plugin refactor (was: 'core' stuff that isn't in plugins) mjml Involves MJML, or the code that handles it help wanted Can you help with this? help offered I would be very happy to help less experienced developers tackle this issue (advice/pairing/etc) labels Oct 6, 2020
@denny
Copy link
Owner Author

denny commented Oct 10, 2020

If you are a less experienced developer who is looking at this issue and thinking you'd like to try to take it on but you're not entirely confident, I would be happy to help you - whether that's help getting set up, more explanation of what needs doing, pairing on the code task itself, or anything else I can do to help.

In my day job I'm a lead developer who often mentors less experienced developers, and I'd love to use some of that experience to help people take their first steps into contributing to open source projects.

@denny
Copy link
Owner Author

denny commented Nov 3, 2020 •
edited
Loading

I just added basic mailer tests for ShinyForms[1] while I was fixing another issue in that plugin. DiscussionMailer and EmailRecipientMailer in the main app already have tests.

That leaves the following mailers still in need of separate tests:

  • UserMailer
  • ShinyNewsletters::NewsletterMailer

[1] https://github.com/denny/ShinyCMS-ruby/blob/main/plugins/ShinyForms/spec/mailers/shiny_forms/form_mailer_spec.rb

@denny denny removed the help wanted Can you help with this? label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This issue should be suitable for less experienced developers help offered I would be very happy to help less experienced developers tackle this issue (advice/pairing/etc) main app DEPRECATED: main_app before the core plugin refactor (was: 'core' stuff that isn't in plugins) mjml Involves MJML, or the code that handles it plugin DEPRECATED: split into core/features/support (was: about a plugin or the code that supports them) tests Tests and test infrastructure (CI, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@denny