Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin search features aren't comprehensive #630

Open
denny opened this issue Oct 6, 2020 · 0 comments
Open

Admin search features aren't comprehensive #630

denny opened this issue Oct 6, 2020 · 0 comments
Labels
help wanted Can you help with this? main app DEPRECATED: main_app before the core plugin refactor (was: 'core' stuff that isn't in plugins) plugin DEPRECATED: split into core/features/support (was: about a plugin or the code that supports them) ruby Involves Ruby code

Comments

@denny
Copy link
Owner

denny commented Oct 6, 2020

Some of the search methods in the admin controllers aren't checking all the fields that a user might want to use to search for that kind of content.

Also, in some cases it would make sense to search against fields from associated objects, which none of the searches currently support - and some of those relationships are polymorphic. For example you might well want to search on /admin/lists/1/subscriptions for a ShinyList::Subscription by putting in the name or email address of the subscriber, which will be either a User or an EmailRecipient.
@denny denny added help wanted Can you help with this? ruby Involves Ruby code plugin DEPRECATED: split into core/features/support (was: about a plugin or the code that supports them) main app DEPRECATED: main_app before the core plugin refactor (was: 'core' stuff that isn't in plugins) labels Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Can you help with this? main app DEPRECATED: main_app before the core plugin refactor (was: 'core' stuff that isn't in plugins) plugin DEPRECATED: split into core/features/support (was: about a plugin or the code that supports them) ruby Involves Ruby code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@denny