Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion: add CBOR encoding/decoding #5479

Closed
benatkin opened this issue Jul 18, 2024 · 2 comments · Fixed by #5909
Closed

suggestion: add CBOR encoding/decoding #5479

benatkin opened this issue Jul 18, 2024 · 2 comments · Fixed by #5909
Labels
feedback welcome We want community's feedback on this issue or PR suggestion a suggestion yet to be agreed

Comments

@benatkin
Copy link

Deno's stdlib has msgpack support. msgpack and CBOR each have pros and cons compared to each other, but this limitation is what gives me the desire to have CBOR:

maximum byte size of a String object is (2^32)-1

A CBOR implementation alongside msgpack here.

Describe alternatives you've considered

There are third party libraries, but this is something I'd like to see in the standard library.

Another nice thing about CBOR is its support for indefinite length items which is good for streaming.
@iuioiua iuioiua changed the title CBOR suggestion: add CBOR encoding/decoding Jul 18, 2024
@iuioiua iuioiua added suggestion a suggestion yet to be agreed feedback welcome We want community's feedback on this issue or PR labels Jul 18, 2024
@BlackAsLight
Copy link
Contributor

For the record, CBOR is still streamable with definite length items. Indefinite length items are for streaming content when you don't know the size before starting. Like applying compression algorithm to some data or converting a file format from one type to another.

@benatkin
Copy link
Author

benatkin commented Jul 25, 2024 •
edited
Loading

Streaming implementations already in @std:

Also looked at the state of DOMParser:

@BlackAsLight BlackAsLight mentioned this issue Sep 4, 2024
Merged
@kt3k kt3k closed this as completed in #5909 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feedback welcome We want community's feedback on this issue or PR suggestion a suggestion yet to be agreed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cbor/unstable): introduce @std/cbor BlackAsLight/std
3 participants
@benatkin @iuioiua @BlackAsLight