Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(collection): Inconsistent behavior between pick and omit #5966

Open
lambdalisue opened this issue Sep 12, 2024 · 0 comments
Open

bug(collection): Inconsistent behavior between pick and omit #5966

lambdalisue opened this issue Sep 12, 2024 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@lambdalisue
Copy link
Contributor

lambdalisue commented Sep 12, 2024

Describe the bug

Found on #5926 (comment)

The code below throws a runtime error on o.foo() but type errors.

import { pick } from "jsr:@std/collections/pick";
import { omit } from "jsr:@std/collections/omit";

class A {
  constructor(public a: string, public b: string, public c: string) {}

  foo(): string {
    return "hello";
  }
}

const obj = new A("a", "b", "c");

const p = pick(obj, ["a", "c", "foo"]);
const o = omit(obj, ["b"]);

console.log(obj.foo());
console.log(p.foo());
console.log(o.foo());

Closely related to #5927

Steps to Reproduce

Expected behavior

While the code doesn't throw type error, we should keep non listed methods in omit (o.foo() should be available.)

Environment

  • OS: [e.g. Ubuntu 20.04, MacOS 11]
  • deno version:
  • std version:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

1 participant