diff --git a/.github/workflows/content-release.yml b/.github/workflows/content-release.yml index 6012f28530..7aae49d7a2 100644 --- a/.github/workflows/content-release.yml +++ b/.github/workflows/content-release.yml @@ -229,10 +229,6 @@ jobs: echo "DEPLOY_ENV=prod" >> $GITHUB_ENV echo "BUILD_TRIGGER=cms" >> $GITHUB_ENV - - name: Check broken links - id: get-broken-link-info - run: node ./script/github-actions/check-broken-links-blocks.js ${{ env.BUILDTYPE }} - - name: Build JSON object for step metrics run: | cat build/${{env.BUILDTYPE}}/metalsmith-step-metrics.json | \ @@ -240,8 +236,7 @@ jobs: jq '.series[].tags[1] = "build_number:${{github.run_number}}"' | \ jq '.series[].tags[2] = "instance_type:${{env.INSTANCE_TYPE}}"' | \ jq '.series[].tags[3] = "heap_size:${{env.MAXIMUM_HEAP}}"' | \ - jq '.series[].tags[4] = "trigger:${{env.BUILD_TRIGGER}}"' | \ - jq '.series[].tags[5] = "broken_links:${{steps.get-broken-link-info.outputs.BROKEN_LINKS || 0 }}"' > metrics.json + jq '.series[].tags[4] = "trigger:${{env.BUILD_TRIGGER}}"' > metrics.json - name: Get Datadog api key from Parameter Store uses: department-of-veterans-affairs/action-inject-ssm-secrets@d8e6de3bde4dd728c9d732baef58b3c854b8c4bb # latest @@ -256,6 +251,10 @@ jobs: -H "DD-API-KEY: ${{ env.GHA_CONTENT_BUILD_DATADOG_API_KEY }}" \ -d @- < metrics.json + - name: Check broken links + id: get-broken-link-info + run: node ./script/github-actions/check-broken-links-blocks.js ${{ env.BUILDTYPE }} + - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@e1e17a757e536f70e52b5a12b2e8d1d1c60e04ef # v2.0.0 if: ${{ steps.get-broken-link-info.outputs.UPLOAD_AND_NOTIFY == '1' && always() }} diff --git a/script/github-actions/check-broken-links-blocks.js b/script/github-actions/check-broken-links-blocks.js index debda17242..c1d70842ca 100644 --- a/script/github-actions/check-broken-links-blocks.js +++ b/script/github-actions/check-broken-links-blocks.js @@ -92,7 +92,6 @@ if (fs.existsSync(reportPath)) { console.log( `${brokenLinks.brokenLinksCount} broken links found. \n ${brokenLinks.summary}`, ); - core.setOutput('BROKEN_LINKS', `${brokenLinks.brokenLinksCount}`); core.setOutput('SLACK_BLOCKS', `${JSON.stringify(payload)}`); if (!IS_PROD_BRANCH && !contentOnlyBuild) {