Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logically Determine Which Celery Tasks To Call - SMS #119

Open
6 tasks
k-macmillan opened this issue Dec 31, 2024 · 0 comments
Open
6 tasks

Logically Determine Which Celery Tasks To Call - SMS #119

k-macmillan opened this issue Dec 31, 2024 · 0 comments
Labels
Dev Reviewed Reviewed by Tech Lead Notify Board trigger PM Reviewed Reviewed by Product Manager QA Reviewed Reviewed by Quality Assurance Ready for Refinement

Comments

@k-macmillan
Copy link
Member

User Story - Business Need

va-enp-api will be able to handle all validation, but lookup VA Profile ID, gathering contact information, and actually sending the notification are all tasks that Celery will still do at first. This method identifies which tasks need to be called and logs them. A future ticket will implement the SQS send_message functionality.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a VA Notify dev
I want to know what tasks a notification still needs to accomplish
So that we can prepare to send them to the appropriate tasks

Additional Info and Resources

These are the three applicable methods:

  • lookup_va_profile_id - MPI call to get a VA Profile ID
  • lookup_contact_info - VA Profile call to get contact information and preferences
  • deliver_sms - Sends an sms

Acceptance Criteria

  • Logic is based on phone_number and recipient_identifier fields
  • phone_number results in only a deliver_sms task
  • recipient_identifier results in an MPI lookup if it's not a VA Profile ID, then a contact lookup, then deliver the sms
  • The output is logged so we can test the logic
  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

Potential Dependencies

Out of Scope

A separate ticket will implement the ETL methods necessary to actually put the desired tasks into SQS.

@k-macmillan k-macmillan added Dev Reviewed Reviewed by Tech Lead Notify Board trigger labels Dec 31, 2024
@k-macmillan k-macmillan changed the title Logically Determine Which Celery Tasks To Call Logically Determine Which Celery Tasks To Call - SMS Dec 31, 2024
@cris-oddball cris-oddball added the QA Reviewed Reviewed by Quality Assurance label Jan 3, 2025
@kbelikova-oddball kbelikova-oddball added PM Reviewed Reviewed by Product Manager Ready for Refinement labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Reviewed Reviewed by Tech Lead Notify Board trigger PM Reviewed Reviewed by Product Manager QA Reviewed Reviewed by Quality Assurance Ready for Refinement
Projects
None yet
Development

No branches or pull requests

3 participants