Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change text of va-button using continue #3724

Open
2 of 6 tasks
rhasselle-oddball opened this issue Jan 23, 2025 · 1 comment
Open
2 of 6 tasks

Cannot change text of va-button using continue #3724

rhasselle-oddball opened this issue Jan 23, 2025 · 1 comment
Labels

Comments

@rhasselle-oddball
Copy link

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

Related to:

What happened

I want to do this:

<VaButton
  continue
  submit="prevent"
  text="Save and continue"
/>

However you cannot override the text when using continue. We need to use continue so that we have the arrows icon next to the text.

What I expected to happen

Should be able to change the text of va-button when continue is set

Reproducing

  • CSS Library version:
  • Device: (e.g. iPhone 8, Macbook)
  • Browser: (e.g. Firefox, IE 11)

Steps to reproduce:

  1. Try using continue with text and notice text does not take effect for va-button

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details

@caw310 caw310 added the va-button DS Buttons label Jan 23, 2025
@micahchiang
Copy link
Contributor

Thanks for submitting this @rhasselle-oddball! I'm going to re-label this as a feature request, since this has been the intended functionality of the continue prop for a while. Either way, we'll get this sized and prioritized in our backlog.

@micahchiang micahchiang added enhancement New feature or request and removed bug Something isn't working labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants