Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config/redirects from os to deriv app to be tested on UAT #17897

Conversation

shahzaib-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

amina-deriv and others added 19 commits November 25, 2024 08:29
* feat: test redirection

* feat: test redirection

* Amina/redirection test (deriv-com#17606)

* feat: test redirection

* feat: test redirection

* fix: query param

* fix: sidebar

* fix: sidebar

* fix: linting --no-verify

* fix: button

* fix: button
- Remove direct redirection to hub.deriv.com from page-overlay
- Add is_from_tradershub_os computed property in common store
- Add platform detection utility for traders hub OS
- Update types and components to handle traders hub OS platform
- Clean up imports organization in page-overlay component
Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 25, 2024 9:21am

Copy link
Contributor

github-actions bot commented Dec 25, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-config-redirects-from-aea58d.binary.sx/

@shahzaib-deriv shahzaib-deriv changed the title Config/redirects from os to deriv app Config/redirects from os to deriv app to be tested on UAT Dec 25, 2024
@shahzaib-deriv shahzaib-deriv merged commit 5f7f7a2 into deriv-com:redirect/test-from-cfd-os Dec 25, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants