-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config/redirects from os to deriv app to be tested on UAT #17897
Merged
shahzaib-deriv
merged 20 commits into
deriv-com:redirect/test-from-cfd-os
from
shahzaib-deriv:config/redirects-from-os-to-deriv-app
Dec 25, 2024
Merged
Config/redirects from os to deriv app to be tested on UAT #17897
shahzaib-deriv
merged 20 commits into
deriv-com:redirect/test-from-cfd-os
from
shahzaib-deriv:config/redirects-from-os-to-deriv-app
Dec 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: test redirection * feat: test redirection * Amina/redirection test (deriv-com#17606) * feat: test redirection * feat: test redirection * fix: query param * fix: sidebar * fix: sidebar * fix: linting --no-verify * fix: button * fix: button
… config/redirects-from-os-to-deriv-app
…ects-from-os-to-deriv-app
…b.com/shahzaib-deriv/deriv-app into config/redirects-from-os-to-deriv-app
… config/redirects-from-os-to-deriv-app
… config/redirects-from-os-to-deriv-app
…b.com/shahzaib-deriv/deriv-app into config/redirects-from-os-to-deriv-app
- Remove direct redirection to hub.deriv.com from page-overlay - Add is_from_tradershub_os computed property in common store - Add platform detection utility for traders hub OS - Update types and components to handle traders hub OS platform - Clean up imports organization in page-overlay component
…b.com/shahzaib-deriv/deriv-app into config/redirects-from-os-to-deriv-app
shahzaib-deriv
requested review from
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
nijil-deriv,
sandeep-deriv and
yashim-deriv
as code owners
December 25, 2024 08:34
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-config-redirects-from-aea58d.binary.sx/ |
shahzaib-deriv
changed the title
Config/redirects from os to deriv app
Config/redirects from os to deriv app to be tested on UAT
Dec 25, 2024
shahzaib-deriv
merged commit Dec 25, 2024
5f7f7a2
into
deriv-com:redirect/test-from-cfd-os
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.