From 381b154c1efee97fc48536c49a9b00a18dd0b6b5 Mon Sep 17 00:00:00 2001 From: Ahrar <98078754+ahrar-deriv@users.noreply.github.com> Date: Wed, 29 Nov 2023 10:52:30 +0800 Subject: [PATCH] chore: add pull request template (#271) --- .github/PULL_REQUEST_TEMPLATE.md | 55 ++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..e708d44da --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,55 @@ + + +**Clickup link:** +**Fixes issue:** # + +This PR contains the following changes: + + + +- [ ] โœจ New feature (non-breaking change which adds functionality) +- [ ] ๐Ÿ› ๏ธ Bug fix (non-breaking change which fixes an issue) +- [ ] โŒ Breaking change (fix or feature that would cause existing functionality to change) +- [ ] ๐Ÿงน Code refactor +- [ ] โœ… Build configuration change +- [ ] ๐Ÿ“ Documentation +- [ ] ๐Ÿ—‘๏ธ Chore + +### Developers Note (Optional) + + + +## Pre-launch Checklist (For PR creator) + +As a creator of this PR: + + + +- [ ] โœ๏ธ I have included clickup id and package/app_name in the PR title. +- [ ] ๐Ÿ‘๏ธ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.). +- [ ] โš’๏ธ I have fixed any errors/warnings shown by the analyzer/linter. +- [ ] ๐Ÿ“ I have added documentation, comments and logging wherever required. +- [ ] ๐Ÿงช I have added necessary tests for these changes. +- [ ] ๐Ÿ”Ž I have ensured all existing tests are passing. + +## Reviewers + + + +## Pre-launch Checklist (For Reviewers) + +As a reviewer I ensure that: + +- [ ] โœด๏ธ This PR follows the standard PR template. +- [ ] ๐Ÿชฉ The information in this PR properly reflects the code changes. +- [ ] ๐Ÿงช All the necessary tests for this PR's are passing. + +## Pre-launch Checklist (For QA) + +- [ ] ๐Ÿ‘Œ It passes the acceptance criteria. + +## Pre-launch Checklist (For Maintainer) + +- [ ] [MAINTAINER_NAME] I make sure this PR fulfills its purpose.