Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGN/QSO Summary Catalog VAC Review (DR1) #27

Open
3 of 4 tasks
dylanagreen opened this issue Dec 30, 2024 · 1 comment
Open
3 of 4 tasks

AGN/QSO Summary Catalog VAC Review (DR1) #27

dylanagreen opened this issue Dec 30, 2024 · 1 comment
Assignees
Labels
vac review Issues pertaining to VAC reviews

Comments

@dylanagreen
Copy link

Contact Person: Mar Mezcua, Steph Juneau, Becky Canning
1 catalog file (fits), 1 README

Initial Checks:

  • Includes README
  • Columns in ALLCAPS
  • Extension names in ALLCAPS
  • Files include units

Initial Notes:

  • File is looking good so far! When you get a chance, can you please add units to columns where necessary (e.g. units of degrees for TARGET_RA and TARGET_DEC, anywhere else as noted in the README)
  • The README indicates that a jupyter notebook will also be released but it doesn't yet exist in the documented location
@dylanagreen dylanagreen self-assigned this Dec 30, 2024
@dylanagreen dylanagreen added the vac review Issues pertaining to VAC reviews label Jan 17, 2025
@stephjuneau
Copy link

Hi @dylanagreen -- thanks for the VAC review! Mar, Becky & I went over it.

  1. Units: I don't have much experience adding units to FITS files but read about it here: https://docs.astropy.org/en/stable/io/fits/index.html#working-with-table-data (And this example shows how to test it, where one can print, say, t["RA"].unit and it should print degrees or whatever the default FITS file unit notation is:
    https://docs.astropy.org/en/stable/io/unified.html#table-io-fits) Is this what we need to do? Is there any automated script that folks are using to pull the units and descriptions from the reference CSV list here: https://github.com/desihub/desidatamodel/blob/main/py/desidatamodel/data/column_descriptions.csv

  2. Tutorial notebook: not yet finalized but we have starting points here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vac review Issues pertaining to VAC reviews
Projects
None yet
Development

No branches or pull requests

2 participants