Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel git operation with CTRL+C signal #536

Closed
wants to merge 18 commits into from
Closed

Cancel git operation with CTRL+C signal #536

wants to merge 18 commits into from

Conversation

maifeeulasad
Copy link
Contributor

closes #524

@maifeeulasad maifeeulasad marked this pull request as draft April 4, 2023 09:48
@maifeeulasad maifeeulasad changed the title WIP: Cancel git operation with CTRL+C signal Cancel git operation with CTRL+C signal Apr 4, 2023
@maifeeulasad
added .cc source to this repo, instead of adding as a dependency
48eacad
@maifeeulasad
remove ctrlc-node-pid from deps
f4504b7
@maifeeulasad
prettify + git clone url gh/desktop/desktop
5d0403a
@maifeeulasad
[pipeline]: add node-gyp globally + configure and build node-gyp, msv…
61a6841 
…c and tools may raise an issue
@maifeeulasad
call sigintWindows only if os is windows and action is clone; keep …
c14dfe6 
…track of git operation type along with pid;
@maifeeulasad
shuflle test to confirm pre-mature exit by ctrl+c;
bb7d2ce
@maifeeulasad
restore pipeline to original one; node-gyp install, configure, build …
15d2df8 
…from script, only runs on windows on post-install
@maifeeulasad
ctrl, conditional import and run, based on `process.platform === 'win…
e1b909c 
…32'`
@maifeeulasad
conditional .cc native code
ad9675d
@maifeeulasad
yarn should trigger node-gyp?
638ebaa
@maifeeulasad
//lint
dd76d01
@maifeeulasad
no conditional import
d7fd1ad
@maifeeulasad
copy .node file from build to lib folder on post-install; putti…
4ae61bc 
…ng `.cc` file in `lib` folder;
@maifeeulasad
//
06a22a1
@niik
Copy link
Member

niik commented Oct 17, 2024

This is out of scope for dugite I'm afraid. Try using the processCallback option to get a reference to the ChildProcess which will let you send the signals you'd like directly to the process.

@niik niik closed this Oct 17, 2024
@niik niik mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

execTask.cancel() doesn't kill the git process properly
2 participants
@maifeeulasad @niik