Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProductOffersRequest and ProductsRequest only return 1 offer instead of all offers. #1

Open
mitchell-amasia opened this issue Jun 15, 2015 · 2 comments

Comments

@mitchell-amasia
Copy link

I have tested this with this product --> http://www.bol.com/nl/p/9200000035330615/9200000035330615
At the time of writing, there were 3 offers on the website. But I only get 1 offer thru the API when using this client.

@derkmdt
Copy link
Member

derkmdt commented Jul 13, 2015

Hi Mitchell-amasia,

Are you aware that by default one offer is returned. See the docs on https://developers.bol.com/documentatie/open-api/handleiding/api-requests/catalog/get-catalogv4products/ . If you specifiy &offers=all , you will get all offers.

Sorry for the late reply :)

@mitchell-amasia
Copy link
Author

Hi @derkmdt ,

Yes, I was aware of that. That was the whole problem.
I was specifying "&offers=all" but I only get 1 offer returned.

The problem was that there was a typing error in the client SDK. ("offer" instead of "offers")
So it always defaulted to return only 1 offer no matter what I specify.

I fixed the issue and created a pull request and it was accepted. So I think this issue should be closed by now :)

Greets,

Mitchell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants