Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this Action obsolete! #4

Open
jcbhmr opened this issue Aug 17, 2023 · 3 comments
Open

Make this Action obsolete! #4

jcbhmr opened this issue Aug 17, 2023 · 3 comments

Comments

@jcbhmr
Copy link
Member

jcbhmr commented Aug 17, 2023

ideally this action should become obsolete because this should be either in the official devcontainer CLI or under @devcontainers official org.

i think devcontainers/action#134 is related to this

@0xE1E10
Copy link

0xE1E10 commented Dec 15, 2023

That seems to exactly be what devcontainers-contrib is doing. https://github.com/devcontainers-contrib/features/blob/main/.github/workflows/release.yaml

Also, there's a bug in this repo. We're generating tarballs with hardlink to itself due to the same file being referenced indirectly thru parent dir. devcontainers/cli#699 (comment) devcontainer CLI and vscode chokes on it. It maybe easier to just retire this and make it Microsoft's problem instead of trying to fix it.

@0xE1E10
Copy link

0xE1E10 commented Dec 22, 2023

If you don't have any objections, I'll try to make the switch in features-llvm to fix devcontainers-community/features-llvm#4 The feature is currently broken and un-usable. So there's no risk.

Probably not worth the time debugging why this action is trigger the bug in dev container CLI for that specific feature. The bug in dev container comes from their upstream in a tar node package so it will probably take a while to get fixed.

@mering
Copy link

mering commented Aug 27, 2024

Thanks @0xE1E10 for pointing me to a workaround. We have the same issue with features-bazel. I also worked around like you did in features-llvm in devcontainers-community/features-bazel#13.

nex3 added a commit to nex3/features-dart-sdk that referenced this issue Aug 31, 2024
This works around a bug where tar files could be generated with two different instances of the same file, which in turn tickles a crashing bug in the container builder (devcontainers/cli#699). This is the same solution as in devcontainers-community/features-llvm#7 and devcontainers-community/features-bazel#13.

Closes devcontainers-community#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants