Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node20 #203

Open
lure8225 opened this issue Dec 6, 2023 · 6 comments
Open

Upgrade to Node20 #203

lure8225 opened this issue Dec 6, 2023 · 6 comments

Comments

@lure8225
Copy link

lure8225 commented Dec 6, 2023

Is there any timeline for an update to Node 20 as Node 16 is out of support since September 11th?
https://nodejs.org/en/blog/announcements/nodejs16-eol

Thanks

@eljog
Copy link
Member

eljog commented Dec 6, 2023

Thank you for opening this issue.

@joshspicer do we have any known reasons to keep the image pinned to Node 16?

@joshspicer
Copy link
Member

No known blockers :)

@eljog
Copy link
Member

eljog commented Dec 6, 2023

@lure8225 thanks again for opening this issue.
I am afraid we have capacity to tackle it in the short term.
Would you be willing to contribute a PR (from a fork) to upgrade Node? We are more than happy to support with the review on your contribution.

@lure8225
Copy link
Author

lure8225 commented Dec 7, 2023

Thanks for the quick reactions, sadly it might take some time until I can properly contribute (company politics/processes). If there are no known issues the change would be just to change the 16 to a 20 here:

using: node16

However there might be some things as you build the actual action from typescript that I'm not aware of as I have not looked into the build process of the action yet.

And most likely tag/release a new version (which I can't do anyway).

@tremblaysimon
Copy link

tremblaysimon commented Feb 27, 2024

Should be close since it has been resolved by #207

@jpawlowski
Copy link

jpawlowski commented Jul 29, 2024

In the meantime, GitHub moved on already:

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants