Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the generateDocs as lib or cli #212

Open
hellodword opened this issue Feb 15, 2024 · 1 comment
Open

Split the generateDocs as lib or cli #212

hellodword opened this issue Feb 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@hellodword
Copy link
Contributor

hellodword commented Feb 15, 2024

So we can use it everywhere not only in the GitHub Actions :)

A simple PoC here: https://github.com/hellodword/action/tree/patch-3

Try it with:

npx ts-node ./src/cli/main.ts features docs --owner ohhh --repo wuw ./__tests__/examples/simple/src

And, would it be better to implement generateDocs and validate things in the upstream cli?

devcontainer features validate
devcontainer features docs
devcontainer templates validate
devcontainer templates docs
...

Two implementations always have differences.

@samruddhikhandale
Copy link
Member

And, would it be better to implement generateDocs and validate things in the upstream cli?

This does make sense and would be nice to extend it for more usage. Feel free to contribute a PR if you are interested, we appreciate support from the community. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants