Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interviews - When leaving blank on initial job entry, it should not make a POST request #56

Open
nosvalds opened this issue Sep 30, 2020 · 1 comment · Fixed by #60
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nosvalds
Copy link
Contributor

Describe the bug
When going through adding a job, the final step is to add interview notes (if you've had one). The form says you can leave it blank if you haven't. However if you do leave it blank the client still makes a POST request to the interviews route and recieves a 422 error.

To Reproduce
Steps to reproduce the behavior:

  1. Login
  2. Add Job
  3. Fill out info on first 2 forms
  4. Leave interviews form blank and click finish + save
  5. Look at Dev Tools

Expected behavior
I would expect the client not to make the POST request if the interview form is left blank by the user

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
NOTE: This probably doesn't need to be fixed for MVP

@nosvalds nosvalds added the enhancement New feature or request label Sep 30, 2020
@kierancott kierancott linked a pull request Oct 9, 2020 that will close this issue
@kierancott kierancott reopened this Oct 13, 2020
@kierancott
Copy link
Contributor

Issue closed in error.

Whilst this has been resolved on the "add a job form", this issue still persists on the "edit single job page".

@kierancott kierancott added the good first issue Good for newcomers label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants