Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git quickstart #377

Open
pvalena opened this issue Apr 15, 2021 · 10 comments
Open

Git quickstart #377

pvalena opened this issue Apr 15, 2021 · 10 comments

Comments

@pvalena
Copy link
Contributor

pvalena commented Apr 15, 2021

I've noticed we're missing a git quickstart.

I've drafted some in:

https://github.com/developer-portal/website/blob/master/DEVELOPMENT.md

(Where we probably need one, or link to a one.)

@pvalena
Copy link
Contributor Author

pvalena commented Apr 15, 2021

@hhorak WDYT?

@hhorak
Copy link
Contributor

hhorak commented Apr 15, 2021

It might be useful for less technical people, so why not. I think the user in the clone command might be also replaced (currently pvalena is mentioned there): https://github.com/developer-portal/website/blame/master/DEVELOPMENT.md#L87
Otherwise LGTM

@pvalena
Copy link
Contributor Author

pvalena commented Apr 15, 2021

It might be useful for less technical people, so why not. I think the user in the clone command might be also replaced (currently pvalena is mentioned there): https://github.com/developer-portal/website/blame/master/DEVELOPMENT.md#L87
Otherwise LGTM

Good catch- that's a mistake.

Thanks for checking

@pvalena
Copy link
Contributor Author

pvalena commented Apr 15, 2021

I'll take a look at it then, which section do you think it should go to? Get Tools or Deploy and Distribute ? :)

@pvalena
Copy link
Contributor Author

pvalena commented Apr 15, 2021

@jackorp WDYT?

@jackorp
Copy link
Contributor

jackorp commented Apr 16, 2021

I'd say it belongs to the Get Tools section as Git is a versioning tool and it would IMHO look out of place in between Openshift RPM and Flatpak and whatnot.

@pvalena
Copy link
Contributor Author

pvalena commented Apr 16, 2021

I'd say it belongs to the Get Tools section as Git is a versioning tool and it would IMHO look out of place in between Openshift RPM and Flatpak and whatnot.

You're right, it's not much of a deploy/distribution tool, outside of source code :). Tools it is. And the guide itself? Would you add something? Can you try it?

@pvalena
Copy link
Contributor Author

pvalena commented Apr 16, 2021

The quay.io container builds are working! https://quay.io/repository/developer-portal/devel?tab=builds

@jackorp
Copy link
Contributor

jackorp commented Apr 16, 2021

I'd say it belongs to the Get Tools section as Git is a versioning tool and it would IMHO look out of place in between Openshift RPM and Flatpak and whatnot.

You're right, it's not much of a deploy/distribution tool, outside of source code :). Tools it is. And the guide itself? Would you add something? Can you try it?

I'll try it later this weekend.

However, from a glance, I don't see setting a name or email? If someone is new to git they probably don't know this needs to be done.

I am also missing adding and committing changes.

@pvalena
Copy link
Contributor Author

pvalena commented Apr 19, 2021

You're right, ... I'd assume people know that, but then again, it would be a bad guide :). I'll add something like that, and create a PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants