Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ability to customize concurrency of gunicorn processes #184

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

alukach
Copy link
Member

@alukach alukach commented Apr 3, 2024

To minimize chatter in the Docker logs, it's nice to be able to disable web concurrency for gunicorn processes.

NOTE: It may be nice to have concurrency be set to 1 by default. I'm assuming the average person running this docker file will be a developer working on their eoAPI solutions locally, when high concurrency is not a strong need.

@alukach alukach marked this pull request as ready for review April 3, 2024 05:37
@vincentsarago
Copy link
Member

does web_concurency=1, fall back to being like uvicorn ?

@alukach
Copy link
Member Author

alukach commented Apr 17, 2024

does web_concurency=1, fall back to being like uvicorn ?

@vincentsarago I honestly don't know, what do you exactly mean by "like uvicorn"? My goal is basically just less noisy logs when developing.

@vincentsarago
Copy link
Member

I meant that if you set web_concurency=1 it might be the same as using Uvicorn directly instead of Gunicorn

https://github.com/tiangolo/uvicorn-gunicorn-docker?tab=readme-ov-file#web_concurrency

@zacharyDez zacharyDez merged commit 65ec346 into main Apr 23, 2024
2 checks passed
@zacharyDez zacharyDez deleted the feature/customizable-gunicorn-concurrency branch April 23, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants