Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip viewer can be too crowded #586

Open
kylebarron opened this issue Jul 30, 2024 · 5 comments
Open

Tooltip viewer can be too crowded #586

kylebarron opened this issue Jul 30, 2024 · 5 comments
Assignees

Comments

@kylebarron
Copy link
Member

When you click on an object, maybe show a sidebar or a collapsible menu.

Overture is a good example. We might want a JSON viewer

@vgeorge
Copy link
Member

vgeorge commented Oct 2, 2024

In #636, we replaced the tooltip with a scrollable side panel. Currently, there is no visual indication that a feature can be clicked to open the side panel, which was not necessary when the tooltip was used.

@kylebarron you suggested documenting this behavior. Do you have any recommendations on the best approach? I still believe it is possible to change the mouse pointer on feature hover to indicate interactivity. We can do something using getCursor like in here, but it might be better to track as an enhancement in a separated ticket.

@kylebarron
Copy link
Member Author

I think documenting it in the release notes and documentation website is fine and sufficient

@ymoisan
Copy link

ymoisan commented Oct 9, 2024

The side panel is a nice addition to lonboard. However, I believe there is still a need for a tooltip, albeit with selectable contents as opposed to dumping it all in the side panel. I have included a video showing the behaviour I'm about to make the following comments on.

  • I play with _height to show the effect of toggling expand/collapse cell output of the map; I'll note that with a height greater than the default cell output height, the toggle has to be "convinced" a little (like click three times before I can see the full map height), but that's not a big deal
  • I like the auto_highlight feature a lot;; when the side panel lets the user see enough of the image to notice the current panel is linked to the highlighted feature, all is fine; however
  • when the side panel covers the entire map, we have a problem; the 'x' becomes a kind of '<' because it is hidden by the bbox button in the top right

Playing with the notebook panel width (e.g. showing the lefthand side Jupyterlab panel) shows how the panel wraps content well. So I'm thinking : is there a way to restrict the side panel to a percentage of the map cell output so as to still be able to see the selected/highlighted feature ?

As to the tooltip functionality, I believe it would still be useful for quick identification of features, when one does not want the whole pedigree. show_tooltip set to True does not show a tooltip. I think if one were to define a tooltip object attached to the map (or layer ?) it should be selectable on the map like the PMTiles Viewer Popup/Show Attributes. I'll try to have a look but you guys are probably in a better position to do an eventual PR.

Thanx again for lonboard, really.

lonboard_4.mp4

@ymoisan
Copy link

ymoisan commented Oct 10, 2024

Even more intuitive IMO : tooltip has instruction "click feature for more details" which pops the side panel.

@kylebarron
Copy link
Member Author

There are definitely some tooltip improvements we need to make. @vgeorge is out this week and hopefully we'll get some fixes in next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants